Autocomplete: Update Livequery plugin

Description

Originally reported on Google Code with ID 3588
What archive revision are you testing on? (See the version label in
the footer, for example v0.8.13.8.)
0.9.6.5

If appropriate, enter the URL of a page where the problem can be seen:

What steps will reproduce the problem? (More to test than to reproduce the problem,
since there's not exactly a problem.)
1. Use the autocomplete.

What is the expected output? What do you see instead?
I expect us to be on a more recent version of livequery than 1.1.1.
http://plugins.jquery.com/livequery/

NOTE: Please do mention if you notice issues with:

  • inconsistency with other things on the archive

  • how this might work for screenreader/mobile/other devices or users with
    other accessibility issues

  • overlap with other features or gap left between features

  • the clarity and conciseness of the text

  • how well one action flows to another

  • how intuitive you find the correct actions

  • if not intuitive, how badly things go wrong if you do what you find
    intuitive

Please use labels and text to provide additional information.

Activity

Show:
ticking instant
December 17, 2020, 3:29 AM

Would it make sense to move the code for scrolling to show_comments.js.erb?

redsummernight
December 17, 2020, 4:21 PM
Edited

We can keep the scrolling code where it is and change the selector in .on to .pagination a[data-remote]. Then we don’t need to include it on each show_comments.js request.

Stephen Burrows
December 19, 2020, 12:28 PM

Thanks for catching this! I’ve made the fix in

Testing:

  1. Visit a page with a large number of comments.

  2. Press the "Show comments" button at the top of the page.

  3. Scroll to the bottom of the page.

  4. Press "next", "previous", or any page number.

  5. Verify that you are scrolled to the top of the comments area, just above the pagination (i.e. NOT including the comment form.)

Sarken
December 24, 2020, 5:29 PM

The pagination fix works! I tried it with the page number and the previous and next buttons, just to be super thorough.

I can also confirm that the autocomplete in the Fandoms field on the work search form works.

QED
December 24, 2020, 7:36 PM

I also tested the pagination fix, and it works with everything - page number, next, previous, all of them.

DeployedToBeta

Assignee

Stephen Burrows

Reporter

Sarken

Roadmap

Misc

Priority

Low

Affects versions

None

Fix versions

Components

FrontEnd

Difficulty

Easy

Milestone

Internal 0.9

Google Code Issue ID

3588