Works not getting added to filters of newly canonized tags

Description

Originally reported on Google Code with ID 3838
What archive revision are you testing on? otwarchive v0.9.10.7

A significant number of newly canonized fandom tags are never getting works in their filters (or getting them really delayed). Usually this process gets queued and runs every 7 minutes; sometimes it's not happening at all.

When this bug occurs, the tag appears on the fandoms list of the work creator’s dashboard, but 0 works appear when following that link.

The fandom does appear on the relevant media page, e.g. https://test.archiveofourown.org/fandoms/Movies, with the proper work count, but 0 works appear when following the link.

Sometimes the tags which show no works also will be unable to be canonized/de-canonized, even if they have no visible child tags (canonical tags with child tags cannot be de-canonized by unchecking the canonical box).

I've also seen it happen when making a new fandom tag into a syn of a new canonical (e.g. fandom tag "Fandooooom A" is synned to new canonical "Fandom A", and then the work for "Fandooooom A" doesn't come up under the Fandom A filter.)

Activity

Show:
Sarken
February 8, 2019, 6:29 AM
teyla
April 25, 2020, 9:44 PM
Edited

I skimmed the ticket and found the following faults mentioned, which I then tested:

FAULT: New fandom canonical doesn’t show its associated works, i. e. it shows up everywhere (Media Page, creator’s dashboard), but its path shows zero work blurbs

TEST:

Unsorted fandom tag: https://test.archiveofourown.org/tags/톰다주/edit - 9 works

  1. Added media tag “Movies”

  2. On edit page of tag, synned to new canonical: https://test.archiveofourown.org/tags/Marvel Cinematic Universe RPF

  3. Changed media tag of subtag to “Celebrities & Real People”

  4. Changed media tag of new canonical to “Celebrities & Real People”

  5. Checked immediately: https://test.archiveofourown.org/media/Celebrities *a* Real People/fandoms

    1. New canonical “Marvel Cinematic Universe RPF” visible

  6. Clicked on new canonical

    1. 9 works visible

  7. Checked creator’s dashboard: https://test.archiveofourown.org/users/michinmoralless/pseuds/michinmoralless

    1. new canonical visible in “Fandoms” list

  8. Clicked on new canonical in “Fandoms” list

    1. all of the author’s works visible on canonical filter page

  9. Posted new work to new canonical: https://test.archiveofourown.org/works/1071203

  10. Went via media page to https://test.archiveofourown.org/tags/Marvel Cinematic Universe RPF/works

    1. new work visible

    2. 10 works total

  11. Checked creator’s dashboard again: https://test.archiveofourown.org/users/michinmoralless/pseuds/michinmoralless and clicked on new canonical in “Fandoms” list

    1. newly created fic not visible, as expected

FAULT: After synning a new, non-canonical fandom tag to an existing canonical fandom tag, the non-canonical fandom tag’s works don’t show up in the existing canonical fandom tag’s filter page.

TEST:

Unsorted fandom tag: https://test.archiveofourown.org/tags/Topp Dogg - 3 works

  1. Added media “Music & Bands”

  2. Synned to existing canonical via tag edit page: https://test.archiveofourown.org/tags/Speed (Kpop)/

  3. Checked immediately via media page: https://test.archiveofourown.org/tags/Speed (Kpop)/works

    1. Works from “Topp Dogg” weren’t visible yet

  4. Checked 10 minutes later via reload: https://test.archiveofourown.org/tags/Speed (Kpop)/works

    1. 3 Works from “Topp Dogg” visible

  5. Checked creator’s dashboard

    1. Canonical visible

  6. Clicked on canonical

    1. All of this creator’s works visible

The following faults were listed and still need testing:

  • “Empty” canonical (canonical that won’t show associated works on filter page) can’t be decanonized → not sure this needs testing, as this shouldn’t happen anymore

  • Removing a subtag via the wrangler edit page doesn’t always actually remove the subtag from the metatag, meaning that the subtag’s works still show up in the metatag’s filter even though the subtag isn’t shown on the metatag’s wrangling page as a subtag anymore → same issues as AO3-4077, was tested there

  • In the above case, the “removed” subtag can’t be re-added as a subtag on the metatag’s wrangling page, meaning works from the subtag stay associated to the metatag, but through a tag association that is “hidden” from the wranglers as it’s not shown on the metatag’s wrangling page → shouldn’t happen anymore, not sure if it needs testing

  • Synning Canonical 1 to Canonical 2 leads to subtags being removed from Canonical 1's wrangling page, since they're now subtags of Canonical 2. This is expected behavior. However, if the syn is undone, the subtags can't always be reassociated to Canonical 1 → this isn’t possible anymore since the “Synonym of”-field was removed from edit pages of canonical tags.

lydia-theda
May 12, 2020, 5:57 PM
Edited

Synning Canonical 1 to Canonical 2 leads to subtags being removed from Canonical 1's wrangling page, since they're now subtags of Canonical 2. This is expected behavior. However, if the syn is undone, the subtags can't always be reassociated to Canonical 1 → this isn’t possible anymore since the “Synonym of”-field was removed from edit pages of canonical tags.

Admins still have this option so this one may yet need testing.

lydia-theda
May 12, 2020, 5:57 PM
Edited

Taking an unsorted fandom https://test.archiveofourown.org/tags/GTOP%20-%20Fandom/edit (4 works by one user)

  1. canonized fandom and added media category Books & Literature

    • checked media/Books & Literature/fandoms: GTOP - Fandom (4) took ~3 minutes to appear

    • checked GTOP - Fandom/works (from edit page): 4 works visible instantly

    • checked user's dashboard: GTOP - Fandom (4) visible instantly, works visible instantly

  2. decanonized fandom tag but left Books & Literature on the tag

    • checked media and user pages: GTOP - Fandom did not appear, as expected

  3. synned tag to Pop Music RPF (existing canonical fandom)

    • needed to refresh edit page to see that syn inherited Celebrities & Real People and Music & Bands media types

    • checked Pop Music RPF/edit: canonical tag inherited Books & Literature media type

    • checked media/Books & Literature/fandoms: Pop Music RPF (276) visible

    • checked user’s dashboard: Pop Music RPF (4) visible instantly, works took ~10 minutes to appear

    • checked Pop Music RPF/works: works tagged with GTOP - Fandom took ~10 minutes to appear

  4. pulled Books & Literature from Pop Music RPF; pulled Books & Literature and Music & Bands from GTOP - Fandom

  5. desynned GTOP - Fandom from Pop Music RPF and synned to GTOP RPF (new canonical)

    • checked GTOP RPF/edit: canonical tag inherited Celebrities & Real People media type

    • checked user’s dashboard: GTOP RPF (4) visible instantly, works took ~10 minutes to appear

    • checked media/Celebrities & Real People/fandoms: GTOP RPF (4) took ~2 minutes to appear

    • checked GTOP RPF/works: works took ~10 minutes to appear

  6. Posted new work using GTOP - Fandom as fandom tag

    • checked GTOP RPF/works: new work took ~2 minutes to appear

  7. Posted new work using GTOP RPF as fandom tag

    • checked GTOP RPF/works: new work took ~1 minute to appear

Seems good.

redsummernight
May 24, 2020, 5:33 AM

Synning Canonical 1 to Canonical 2 leads to subtags being removed from Canonical 1's wrangling page, since they're now subtags of Canonical 2. This is expected behavior. However, if the syn is undone, the subtags can't always be reassociated to Canonical 1.

Nothing prevents a tag being made subtags to multiple canonicals. We should be good.

Assignee

ticking instant

Reporter

xparrotx

Roadmap

Tags
Tag Wrangling

Priority

Highest

Affects versions

None

Fix versions

Components

BackEnd

Difficulty

Hard

Required Access Level

Tag Wrangler

Epic Link

Milestone

Internal 0.9

Google Code Issue ID

3838
Configure