Originally reported on Google Code with ID 3945

What archive revision are you testing on?

v0.9.14.5

What steps will reproduce the problem?

1. Post a work with some tags

2. Edit the work and change the order of some or all of the tags

3. Update, with or without previewing first

What is the expected output?

Expect to see your tag order changes.

What do you see instead?

Instead, the tags are in their original order.

Workaround

Remove all tags, update the work, edit again, then re-add in the order you want.

Notes

This bug exists because tags (taggings) are not given a particular assigned order, as they would be if we used acts_as_list (which we use for ordering chapters, for example). Instead, tags are listed on the work in the same order they exist in and are retrieved from the database. Since reordering doesn’t destroy and recreate the taggings, this order doesn’t change.

We have not yet decided on the proper approach to fix this. Two possible solutions:

• Destroy and recreate all taggings when reordering. This might be somewhat inefficient (e.g. it might lead to works' filters being unnecessarily recalculated and the work being unnecessarily reindexed).

• Use acts_as_list to make the order explicit. This would require a migration of the taggings table, and we’d also need to determine whether tags should be ordered as one big list, or with each type (fandom, relationship, etc) as its own list (in case we want to change how tags are displayed in the blurb, e.g. make characters come before relationships).