Inconvenient caching on challenge signup page affects seeing tag sets

Description

  1. Create a tag set with 20+ characters and relationships each.

  2. Create a challenge using that set

  3. Sign up for the challenge

  4. on the /collections/$COLLECTION/signups/new page, click on "Show Characters" then "Show Relationships"

If "lucky", the cache kicks in and either "Show Characters" will show the relationships, or vice versa.

Even if the correct type of tags shows, the tags in it may be wrong (especially if wrangling, not edits to the tag set, has changed the tags).

There is also a fandoms version of this page, e.g. http://archiveofourown.org/tag_sets/show_options?restriction=10986&tag_type=fandom

https://otw.16bugs.com/projects/4911/bugs/352498
https://otw.16bugs.com/projects/4911/bugs/352733

Testing

  • Make sure the Show Characters/Relationships/Fandoms pages show the right kind of tags.

  • After visiting the Show Characters/Relationships/Fandoms page, try modifying the tags in the tag set, and making sure the page updates.

  • After visiting the Show Characters/Relationships/Fandoms page, as a wrangler, try editing the diacritics or suffix of a tag in the tag set and checking if the page updates.

Activity

Show:
Sarken
March 14, 2019, 3:35 AM

https://github.com/sarken/otwarchive/pull/new/AO3-4353_tag_set_cache for when the pull request mountain is a bit smaller

Sarken
October 9, 2019, 11:24 PM

Tagged for 0.9.257 not because this is urgent, but because it also conveniently fixes which is urgent.

redsummernight
October 19, 2019, 5:14 AM

( looks good.)

Now for some tag wrangling:

Looks good.

Lady Oscar
October 24, 2019, 8:22 PM

1) Created a tag set with more than 20 of each kind of tag
2) Created a gift exchange using that tag set
3) Went to the signup form and clicked on each "List [X] [Tag Type]" button

All tag types gave me a full list containing the correct tags

4) Edited the tag set to remove a relationship and add a character, then reloaded the signup form and went to the Character and Relationship lists

Both lists reflected the updates

Lady Oscar
October 25, 2019, 4:57 AM

5) Edited the William Adama character tag to make it William Adáma

Change shows on "List 23 Characters" page. As noted by redsummernight above, change doesn't appear in tag set until the tag set is edited.

Looks good!

DeployedToBeta

Assignee

Sarken

Reporter

CJ Record

Roadmap

Challenges
Tag Sets

Priority

Medium

Affects versions

Fix versions

Components

Caching

Difficulty

Medium

Milestone

Internal 0.9
Configure