Details
-
Type:
Improvement
-
Status: Deployed
-
Priority:
Medium
-
Resolution: DeployedToBeta
-
Affects Version/s: 0.9.168
-
Fix Version/s: 0.9.172
-
Required Access Level:Admin
-
Epic Link:
-
Milestone:Internal 0.9
-
Difficulty:Medium
-
Roadmap:Admin
-
Components:BackEnd
Description
Brakeman says:
Admin::BannersController
create
Unprotected mass assignment near line 27: AdminBanner.new(params[:admin_banner])
Admin::BannersController
update
Unprotected mass assignment near line 46: AdminBanner.find(params[:id]).update_attributes(params[:adm...
How to test:
94% automated test coverage.
For manual testing, make sure you can make a new banner without an error:
1. Log in as admin at http://test.ao3.org/admin/login
2. Banners > New Banner
3. Fill in the form
4. Press "Create Banner"
And make sure you can edit a banner without an error message:
1. Log in as admin at http://test.ao3.org/admin/login
2. Banners
3. Choose "Edit Banner" on an existing banner
4. Make any changes you want
5. Press "Update Banner"
It wouldn't be a bad idea to make sure you can use the banners, too.
