Details

    • Type: Improvement
    • Status: Deployed
    • Priority: Medium
    • Resolution: DeployedToBeta
    • Affects Version/s: 0.9.168
    • Fix Version/s: 0.9.171
    • Required Access Level:
      Admin
    • Milestone:
      Internal 0.9
    • Difficulty:
      Medium
    • Roadmap:
      Admin, Internationalization
    • Components:
      BackEnd

      Description

      Brakeman says:
      LanguagesController
      create
      Unprotected mass assignment near line 22: Language.new(params[:language])

      LanguagesController
      update
      Unprotected mass assignment near line 37: Language.find_by_short(params[:id]).update_attributes(param...

      How to test:
      92% automated test coverage. For manual testing, we'll want to check that we can create and edit a language without fun new errors. (Languages are used for the Support and Abuse forms and for classifying and filtering works.)

      Create a language:
      1. Log in as admin
      2. Go to http://test.archiveofourown.org/languages because we don't have it linked anywhere, oops
      3. Choose "Add a language"
      4. Fill in the form
      5. Press "Create Language"

      Edit a language:
      1. Log in as admin
      2. Go to http://test.archiveofourown.org/languages
      3. Choose "Edit" on an existing language
      4. Make any changes on the form
      5. Press "Update Language"

        Attachments

          Activity

            People

            • Assignee:
              kamilogorek Kamil Ogórek
              Reporter:
              sarken sarken
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: