Details

    • Type: Improvement
    • Status: Deployed
    • Priority: Medium
    • Resolution: DeployedToBeta
    • Affects Version/s: 0.9.168
    • Fix Version/s: 0.9.172
    • Required Access Level:
      Admin
    • Milestone:
      Internal 0.9
    • Difficulty:
      Medium
    • Roadmap:
      Admin
    • Components:
      BackEnd

      Description

      Brakeman says:
      AdminPostsController
      create
      Unprotected mass assignment near line 59: AdminPost.new(params[:admin_post])

      AdminPostsController
      update
      Unprotected mass assignment near line 72: AdminPost.find(params[:id]).update_attributes(params[:admin...

      How to test:
      Has 90% test coverage.

      We'll want to check that we can create and edit news posts without an error using various combinations of fields (e.g. a post with tags, a post that's a translation of another post, a post in a different language):
      1. Log in as admin at http://test.ao3.org/admin/login
      2. Admin Posts > Post AO3 News
      3. Fill out the form
      4. Press "Post"
      5. Choose "Edit Post"
      6. Make changes
      7. Press "Post"

        Attachments

          Activity

            People

            • Assignee:
              kamilogorek Kamil Ogórek (Inactive)
              Reporter:
              sarken sarken
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: