Uploaded image for project: 'Archive of Our Own'
  1. Archive of Our Own
  2. AO3-4759

Strong parameters: Feedbacks aka Support

    Details

    • Type: Improvement
    • Status: Deployed
    • Priority: Medium
    • Resolution: DeployedToBeta
    • Affects Version/s: 0.9.168
    • Fix Version/s: 0.9.173
    • Required Access Level:
      Support
    • Milestone:
      Internal 0.9
    • Difficulty:
      Medium
    • Roadmap:
      Misc
    • Components:
      BackEnd

      Description

      Brakeman says:
      FeedbacksController
      create
      Unprotected mass assignment near line 16: Feedback.new(params[:feedback])

      How to test:
      Has 90% automated test coverage.

      We should test that you can submit a new support request by filling in various combinations of fields while logged in and logged out.
      1. Log in, if desired
      2. Follow the "Technical Support and Feedback" link at the bottom of any page
      3. Fill in the form
      4. Press "Send"

      The form should submit successfully and you should get a confirmation email and Support should get a ticket.

      (Note: This works a little differently in development environments than on production and staging – the development environment won't create a Support ticket.)

        Attachments

          Activity

            People

            • Assignee:
              donat Don Denoncourt (Inactive)
              Reporter:
              sarken sarken
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: