Details

    • Type: Improvement
    • Status: Deployed
    • Priority: Medium
    • Resolution: DeployedToBeta
    • Affects Version/s: 0.9.169
    • Fix Version/s: 0.9.182
    • Required Access Level:
      Admin
    • Milestone:
      Internal 0.9
    • Difficulty:
      Medium
    • Roadmap:
      Admin
    • Components:
      BackEnd

      Description

      Brakeman says:
      ArchiveFaqsController
      create
      Mass Assignment
      Unprotected mass assignment near line 71: ArchiveFaq.new(params[:archive_faq])

      ArchiveFaqsController
      update
      Mass Assignment
      Unprotected mass assignment near line 86: ArchiveFaq.find_by_slug(params[:id]).update_attributes(para...

      How to test:
      This has 80% automated test coverage. This warnings are for both creating and updating FAQs, so that is what we'll want to test manually.

      1. Log in as admin
      2. Admin Posts > Archive FAQ > New FAQ Category
      3. Fill out the form
      4. Press "Post"
      5. Follow "Edit"
      6. Change information on form
      7. Press "Post"

      Try both editing and creating with a few combinations of required and optional fields and ensure that your changes are saved and no unexpected error messages happen.

      You'll also need to test reordering FAQ categories and ensure your changes are saved and no unexpected error messages occur. Repeat steps 2-4 from above to create at least one more FAQ category before testing the reordering process in the following ways:

      With JavaScript disabled:

      1. Admin Posts > Archive FAQ > Reorder FAQs
      2. Change the order by entering a number in the little input field before each category's current position and name (e.g. enter "2" in the input field before "1. Whatever you named your first category")
      3. Press "Update Positions"
      4. Check that the FAQ categories are in the order you expect

      With JavaScript enabled, by entering numbers:

      1. Admin Posts > Archive FAQ > Reorder FAQs
      2. Change the order by entering a number in the little input field before each category's current position and name (e.g. enter "2" in the input field before "1. Whatever you named your first category")
      3. Press "Update Positions"
      4. Check that the FAQ categories are in the order you expect

      With JavaScript enabled, by dragging and dropping:

      1. Admin Posts > Archive FAQ > Reorder FAQs
      2. Drag and drop the grey rectangle containing the category's information to rearrange
      3. Press "Update Positions"
      4. Check that the FAQ categories are in the order you expect

        Attachments

          Activity

            People

            • Assignee:
              davidstump David Stump
              Reporter:
              sarken sarken
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: