Uploaded image for project: 'Archive of Our Own'
  1. AO3-4797

Increase Works Controller coverage - part 2

    Details

    • Type: Improvement
    • Status: Deployed
    • Priority: Medium
    • Resolution: DeployedToBeta
    • Affects Version/s: 0.9.171
    • Fix Version/s: 0.9.175
    • Milestone:
      Internal 0.9
    • Difficulty:
      Medium
    • Roadmap:
      Work
    • Components:
      AutomatedTests

      Description

      AO3-4722 Deployed increased the coverage for the works controller by adding coverage to the clean_work_search_params before_filter and the import action.

      The following actions still have one or more lines which are not covered by our current tests: collected, drafts, create, edit, update, update_tags, preview_tags, destroy, import_single, import_multiple, post_draft, show_multiple, edit_multiple, confirm_delete_multiple, update_multiple, reindex, load_owner, load_work, set_author_attributes, cancel_posting_and_redirect, tag_list, index_page_title, and the private method: preview_mod

      In many cases, the uncovered area is a single error message or edge case, so it's actually less scary than it looks. However, I may create another third issue to cover some of the above if I feel the pull request for this one is becoming too large to review.

        Attachments

          Activity

            People

            • Assignee:
              ariana Ariana
              Reporter:
              ariana Ariana
            • Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: