Details

    • Type: Improvement
    • Status: Deployed
    • Priority: Medium
    • Resolution: DeployedToBeta
    • Affects Version/s: 0.9.171
    • Fix Version/s: 0.9.175
    • Milestone:
      Internal 0.9
    • Difficulty:
      Medium
    • Roadmap:
      Subscription
    • Components:
      BackEnd

      Description

      Brakeman says:
      Brakeman thinks there is no mass assignment, but we have discovered that enabling ForbiddenAttributesProtection in the Subscription model leads to the following error:

      ActiveModel::ForbiddenAttributes (ActiveModel::ForbiddenAttributes)
      ./app/controllers/subscriptions_controller.rb:28:in `create'

      The line is:

      @subscription = @user.subscriptions.build(params[:subscription])

      How to test:
      85% automated test coverage. Successfully creating a new subscription is well-covered in that 85%, but if you want to test manually, just check really quick that you can subscribe to something:

      1. Log in
      2. Hi, username! > My Dashboard
      3. Press the "Subscribe" button to subscribe to yourself

      If you can successfully create a subscription, this is all set.

        Attachments

          Activity

            People

            • Assignee:
              sarken sarken
              Reporter:
              sarken sarken
            • Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: