Details

    • Type: Improvement
    • Status: Deployed
    • Priority: Medium
    • Resolution: DeployedToBeta
    • Affects Version/s: 0.9.171
    • Fix Version/s: 0.9.175

      Description

      Brakeman says:
      Brakeman thinks there is no mass assignment, but enabling ForbiddenAttributesProtection in the FavoriteTag model will lead to the following error:

      ActiveModel::ForbiddenAttributes (ActiveModel::ForbiddenAttributes)
      ./app/controllers/favorite_tags_controller.rb:11:in `create'

      The line is:

      @favorite_tag = current_user.favorite_tags.build(params[:favorite_tag])

      How to test:
      82% automated test coverage. Successfully creating a new favorite tag is well-covered in that 82%, but if you want to test manually, just check really quick that you can favorite a tag:

      1. Log in
      2. Browse > Tags
      3. Follow one of the tag links in the cloud
      4. Press the "Favorite Tag" button

      If you can successfully create a favorite tag, this is all set.

        Attachments

          Activity

            People

            • Assignee:
              sarken sarken
              Reporter:
              sarken sarken
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: