Uploaded image for project: 'Archive of Our Own'
  1. Archive of Our Own
  2. AO3-4809

Extend tests for bookmarks_controller.rb

    Details

    • Type: Improvement
    • Status: Deployed
    • Priority: Medium
    • Resolution: DeployedToBeta
    • Affects Version/s: None
    • Fix Version/s: 0.9.180
    • Milestone:
      Internal 0.9
    • Difficulty:
      Medium
    • Roadmap:
      Bookmark
    • Components:
      AutomatedTests

      Description

      The bookmarks_controller.rb file currently has 79.88% test coverage on Coveralls:
      https://coveralls.io/builds/9474724/source?filename=app%2Fcontrollers%2Fbookmarks_controller.rb

      We'd like to increase that, with an ultimate goal of 90% or greater.

      How to test:
      Use Coveralls to confirm that the coverage percentage has increased:
      1. Go to https://coveralls.io/github/otwcode/otwarchive?branch=master
      2. In the "Search" field near the "Source Files on Master" heading, enter the name of the controller: bookmarks_controller
      3. Note the number in the "Coverage" column of the table, it should be greater than 79.88%

      The blue flash message has been changed for when you add a bookmark to a moderated collection.

      If you EDIT an existing bookmark and attempt to add it to a single moderated collection, it should flash the message:

      "You have submitted your bookmark to the moderated collection 'Some Collection'. It will not become a part of the collection until it has been approved by a moderator."

      If you EDIT an existing bookmark and add it to two or more moderated collections (at the same time), the message should say:

      "You have submitted your bookmark to the moderated collections (Some Collection One, Some Collection Two). It will not become a part of those collections until it has been..."

        Attachments

          Activity

            People

            • Assignee:
              ScottSDS ScottSDS
              Reporter:
              ScottSDS ScottSDS
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: