Uploaded image for project: 'Archive of Our Own'
  1. Archive of Our Own
  2. AO3-4835

Unreachable branch in load_tag_set in owned_tag_sets_controller

    Details

    • Type: Improvement
    • Status: Deployed
    • Priority: Medium
    • Resolution: DeployedToBeta
    • Affects Version/s: 0.9.180
    • Fix Version/s: 0.9.181
    • Milestone:
      Internal 0.9
    • Difficulty:
      Medium
    • Roadmap:
      TagSets
    • Components:
      BackEnd

      Description

      When the OwnedTagSet isn't found, there should be a flash notice and a redirect to the tag_sets_path. However, .find raises an ActiveRecord error instead, which results in a 500.

      https://github.com/otwcode/otwarchive/blob/master/app/controllers/owned_tag_sets_controller.rb#L11

        Attachments

          Activity

            People

            • Assignee:
              potatoesque potatoesque
              Reporter:
              potatoesque potatoesque
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: