Extend tests for kudos_controller, fix 500 leaving kudos on non-existent work

Description

The test coverage for the kudos_controller is 84.21%:
https://codecov.io/gh/otwcode/otwarchive/src/52bcf7b3da114c60d802205a82e25278549a902c/app/controllers/kudos_controller.rb

We'd like to increase that with an ultimate goal of 90% or greater.

How to test:

Activity

Show:
Sarken
January 27, 2020, 9:59 PM

Coverage has actually gone down from when this issue was created – it’s reporting 82.05%.

Trying to leave kudos on a work I just deleted gave me a 404 error instead of a 500, so that’s good!

redsummernight
January 28, 2020, 3:01 AM

Coverage went down because of flaky tests. From the latest build that succeeds, coverage is 100%:

https://codecov.io/gh/otwcode/otwarchive/src/b3c9f726a879b754c84a960d1611f0037dcef0f4/app/controllers/kudos_controller.rb

cosette
February 2, 2020, 6:28 PM

coverage is showing 89.74%

for the second part of the test, i got "Error 404 The page you were looking for doesn't exist. You may have mistyped the address or the page may have been deleted."

looks good!

DeployedToBeta

Assignee

Tal Hayon

Reporter

Sentra Zeal

Roadmap

Misc

Priority

Medium

Affects versions

Fix versions

Components

AutomatedTests
BackEnd

Difficulty

Medium

Milestone

Internal 0.9
Configure