Admin: Remove notifications feature

Description

1. Log in as admin
2. See Notifications section in admin navigation
3. Get Ideas about actually using this feature

We want to remove this because:

  • Neither the feature nor the interface were designed for a site with a million users

  • Ergo, we don't use it

  • Which is good because using it to email all of the users would make the Archive explode

To test:

  • log in as admin and make sure you no longer see "Notifications" in the navigation

  • make sure http://test.archiveofourown.org/admin/users/notify redirects to http://test.ao3.org/admin/users

  • make sure searching for a user as an admin and following the Details link shows you the User History

  • log in as a regular user and make sure the preference to "Turn off admin emails" no longer appears in the Comments section of your preferences page

Activity

Show:
Lady Oscar
July 24, 2017, 3:41 AM
Sarken
July 23, 2017, 10:50 PM

Note: The BOT behavior described above turned out to be an existing issue (AO3-4870), but we've merged it as a BOT fix for this anyway

Sarken
July 23, 2017, 4:15 AM

2) Now has a pull request at https://github.com/otwcode/otwarchive/pull/2968, and the test instructions have been updated. Basically, now that notify route was removed, the code will look for a user named notify, the same way it looks for a user named "testy" if you do http://test.ao3.org/admin/users/testy. So using any non-existent user name (including "notify") should now redirect you to http://test.ao3.org/admin/users/ instead of giving a 500 error.

Basically, it was an existing issue that was revealed by this change.

Lady Oscar
July 23, 2017, 3:44 AM
Edited

1) Logged in as admin, went to look at navigation. There is no longer a "Notifications" menu. (Bonus, the menu list is now shorter and less likely to wrap!)

2) http://test.archiveofourown.org/admin/users/notify gives Error 500 rather than Error 404 [Note: Is this a problem?]

3) As a regular user, the preference "Turn off admin emails" no longer exists. (Conveniently also making it so that having that preference under "Comments" doesn't seem weird.)

DeployedToBeta

Assignee

Sarken

Reporter

Sarken

Roadmap

Admin

Priority

Medium

Affects versions

Fix versions

Components

BackEnd

Difficulty

Medium

Required Access Level

Admin

Milestone

Internal 0.9