Importing a work to the same email address that has orphaned prior imported works adds the orphaned works back onto the account that orphaned them.

Description

Importing a work to the same email address that has orphaned prior imported works adds the orphaned works back onto the account that orphaned them.

  1. Import a work A using an account with archivist permissions (e.g. testy) and "import for others" to email address X

  2. Receive claim email to email X listing work A

  3. Claim work A and add it to to AO3 account Y.

  4. Orphan work A

  5. Import a work B using "OD's import for others tool" to an email address X

  6. Receive "Works Uploaded" email to email X listing work A and work B

  7. Notice that work A is now on the orphan_account as well as account Y.

This also happens if you orphan directly from the claim page rather than claiming then orphaning.

It also happens if X is already associated with account Y in step 1 and you just receive the "Uploaded works" email

After orphaning, checking the external author identity using Open Door's tool reveals the works are still attached to the identity, but when the works are viewed they display on the orphan account

Also, i don't know if this is related but it seems likely - searching for username Y in admin Find Users brings up the orphan_account well as account Y. Names and emails are not even fuzzily related, as far as i can tell.

Activity

Show:
Ariana
July 2, 2017, 2:12 PM
Edited

Note that this is a different manifestation of the problems also described in and and these tickets will all probably be resolved by fixing the persistent connection between external authors and subsequently orphaned works.

Ariana
June 26, 2017, 11:22 AM

Every time you import a work, the code rounds up all unclaimed works for that external author and adds them to the user account that claimed that external author. Since the orphaned works don't already belong to the user, it will helpfully dump them back onto the user's account. So two things probably need to happen to stop this:

1. Orphaning should also destroy any ExternalCreatorships associated with the work (so the work no longer belongs to the external author in the first place)
2. To prevent this happening for previously orphaned works and in the general interest of robustness, the claim code should exclude works belonging to the orphan_account from its "round up previous works" process

Assignee

Unassigned

Reporter

Alison Watson

Roadmap

Work Importing

Priority

Medium

Affects versions

Fix versions

None

Components

BackEnd

Difficulty

Medium

Required Access Level

Archivist

Milestone

Internal 0.9