Changes to work or chapter author/creator or co-author/co-creator do not show up on preview

Description

Steps to reproduce

This bug also happens when editing a work or chapter and choosing a different pseud in the "Creator/Pseud(s)" field. (You must have multiple pseuds on your account to see that option on the form.) You can substitute "Choose a different pseud under 'Creator/Pseud(s)'" for the "Check 'Add co-creators?'" and "Fill in a name' steps in any of these scenarios.

Scenario 1: Editing work to add co-creator during initial posting process

  1. Log in

  2. Post > New Work

  3. Fill in required information

  4. Press "Preview"

  5. Follow "Edit" link on preview page

  6. Check "Add co-creators?"

  7. Fill in a name

  8. Press "Preview"

Scenario 2: Editing posted work to add a co-creator

  1. Log in

  2. Post > New Work

  3. Fill in required information

  4. Press "Post Without Preview"

  5. Follow "Edit" link at top of work

  6. Check "Add co-creators?"

  7. Fill in a name

  8. Press "Preview"

Scenario 3: Editing chapter to add a co-creator during initial posting process

  1. Log in

  2. Post > New Work

  3. Fill in required information

  4. Press "Post Without Preview"

  5. Follow "Add Chapter"

  6. Fill in required information

  7. Press "Preview"

  8. Press "Edit" on the preview page

  9. Check "Add co-creators?"

  10. Fill in a name

  11. Press "Preview"

Scenario 4: Editing posted chapter to add a co-creator

  1. Log in

  2. Post > New Work

  3. Fill in required information

  4. Press "Post Without Preview"

  5. Follow "Add Chapter"

  6. Fill in required information

  7. Press "Post Without Preview"

  8. Follow "Edit Chapter" link

  9. Check "Add co-creators?"

  10. Fill in a name

  11. Press "Preview"

What happens

The preview shows only the username/pseud I original posted with in the byline.

What should happen

I should see the co-creator I added or the pseud I selected.

Notes

The byline isn't cached in the view – it's part of the byline helper (https://github.com/otwcode/otwarchive/blob/ab0e0b25f09613ca27de365bcb9f1a750bb80f95/app/helpers/application_helper.rb#L98) which is using the cached non_anonymous_byline helper (https://github.com/otwcode/otwarchive/blob/ab0e0b25f09613ca27de365bcb9f1a750bb80f95/app/helpers/application_helper.rb#L110).

is also caused by this caching.

Activity

Show:
Sarken
August 24, 2019, 11:51 PM
  1. Used testy, because they’re an archivist and only archivists can add people without approval. Worked dandy! The second preview showed my new co-creator sarken in the byline. I posted the work so I could use it for scenario two.

  2. Also worked dandy! I added nivens as a third author on the work from scenario 1 and they were there on the preview. Posted it.

  3. Kept using the same work, started to add a chapter that would’ve been just testy’s, edited it to add both sarken – who is already on the work – and testy3, who was not on the work. sarken, testy3, and test were all there on the preview page. Posted.

  4. Once more! Same work, same chapter from previous step. Added nivens (already on the work) and testy4 (not one the work). The gang was all there when I previewed.

Looks good!

Nary Rising
August 18, 2019, 3:03 AM
  1. Created a work with testy, previewed, edited to add testy6 as a co-author. Previewed again. Both usernames correctly showed up in the preview byline, and once the work was posted. Looks good.

  2. Edited an existing work to add testy3 as a co-author, previewed. All creators' usernames correctly showed up in the preview and once the work was posted. Looks good.

  3. Added a chapter to an existing work, previewed, edited to add testy6 as a co-author, previewed again. Testy and testy6 both show up in the byline in the preview and once the work is posted. Looks good.

  4. also known as 3 Added a chapter, posted it, then edited it to add testy6 as a co-author, previewed. Both usernames show up in the preview as well as once the work is posted. Looks good.

 

I also tested all of these with just switching the pseud of the creator, and they all worked correctly that way too! \o/

 

DeployedToBeta

Assignee

ticking instant

Reporter

Sarken

Roadmap

Works

Priority

Medium

Affects versions

Fix versions

Components

BackEnd
Caching

Difficulty

Medium

Milestone

Internal 0.9