If you close signups for a challenge before the set closing time, the blurb has a time paradox

Description

How to replicate the issue:

1) Create or edit a Gift Exchange or Prompt Meme such that:
"Sign-ups open?" is unticked
"Sign-up closes:" is set to a date in the future

What you expect to see:

The challenge Profile should show that signups are closed as of some time in the past.

What you actually see:

The challenge Profile shows "Sign-up: Closed (on [FUTURE DATE])"

What should happen:

The date didn't reflect when the challenge was actually closed, just the time that was set by the mod. Ergo, we will remove it.

Note:

The pull request also changes the "Authors Revealed" item on the profile and the form to "Creators Revealed," so make sure to check that, too, please!

Activity

Show:
redsummernight
November 16, 2019, 9:58 PM
Edited

Prompt meme:

  • Edited the challenge to be not open, with a future closed date. I got "Sign-up: Closed" on the profile, without a date next to it.

  • Set the base collection to anonymous. The Challenge Settings form has the field "Creators revealed:" with working label association. Editing the field correctly updates "Creators Revealed:" on the challenge profile.

Gift exchange:

  • Edited the challenge to be not open, with a future closed date. I got "Sign-up: Closed" on the profile, without a date next to it.

  • The base collection is not anonymous. The field "Creators revealed:" doesn't appear.

Looks good.

redsummernight
November 16, 2019, 10:02 PM
Edited

McBangle:

I unticked "Sign-ups: Open" and set Sign-ups close to 2019-11-23 at https://test.archiveofourown.org/collections/Nov19McBTest/profile. It displays as Sign-up: Closed (no date listed)

DeployedToBeta

Assignee

Sarken

Reporter

Lady Oscar

Roadmap

Challenges

Priority

Medium

Affects versions

Fix versions

Components

BackEnd

Difficulty

Medium

Milestone

Internal 0.9
Configure