Upgrade TinyMCE to 5.0.16

Description

We're using TinyMCE 4.3.2, but TinyMCE is up to version 4.6.7 as of the creation of this issue. Our version is almost two years old, so it's a good idea to upgrade to take advantage of bug fixes.

The version used in the merged pull request is 5.0.16.

Testing:
Refer to https://wiki.transformativeworks.org/mediawiki/Testing_the_Rich_Text_Editor.

Retroactive testing notes:

  • Check that TinyMCE does not switch to a more limited mobile version on mobile devices ().

  • Check that TinyMCE does not override the browser's context menu ().

Activity

Show:
Briar
October 24, 2019, 11:06 PM
Edited

Tested in Firefox 69.0.3 on Windows 10.

All of the buttons in the new RTE are present and functional, although now that I’ve been asked to test it all, I noticed that there aren’t any buttons for header text (h1, h2, etc.), so users have to paste in from elsewhere or use the HTML editor to use that kind of formatting.

I also noticed that the RTE on staging took a bit longer to load than the one currently on AO3, though I don’t know if that’s something to do with staging or the editor itself. The new version was, hm, about half a second slower to load.

After noodling around for a while on staging, I copied & pasted formatted text from a few of the samples on the wiki. I used the following samples: the HTML file (master document), the OpenOffice .odt file created on Windows Vista, the Word 2004 .doc file created on OS X 10.5.8, and the document on Google Drive.

All formatting was preserved when pasting from HTML into the RTE.

Blockquote formatting wasn’t preserved when pasting from Word .doc, OpenOffice .odt, or Google Drive—although I don’t think they were in the original GD document to begin with, so the test for that one is inconclusive.

Text alignment wasn’t preserved when pasting from Google Drive.

Sarken
October 25, 2019, 1:22 AM

I noticed that there aren’t any buttons for header text (h1, h2, etc.), so users have to paste in from elsewhere or use the HTML editor to use that kind of formatting.

Good point – we should think about adding those in the future.

Google Drive—although I don’t think they were in the original GD document to begin with, so the test for that one is inconclusive.

Correct! Google doesn’t actually have a blockquote option. The closest they have is indenting, which is unfortunately not the same and thus will not work.

It might be a good idea to check if the Word and OpenOffice behavior is the same with the current RTE.

Text alignment wasn’t preserved when pasting from Google Drive.

This is consistent with the current RTE behavior, so at least it’s not more broken.

Briar
October 25, 2019, 4:13 AM

Tested again in Chrome on Google Chrome OS (version 77).

All of the buttons in the new RTE are present and functional. Again, the version on staging took longer to load than the version currently on AO3, though I don’t know if that’s because of staging or the editor itself.

My Chromebook has limited file capabilities, so I could only test the samples from HTML and Google Drive. They had the same results as my Firefox test (everything was preserved from the HTML sample formatting, while text alignment was lost from GD).

It might be a good idea to check if the Word and OpenOffice behavior is the same with the current RTE.

I can check these on Windows 10 at work tomorrow!

Briar
October 25, 2019, 4:17 PM
Edited

Update: I tested the files again in both the current RTE and the new RTE (in Firefox 69 on Windows 10), and their behavior was the same across the board; neither RTE preserved blockquote formatting when pasting in from Word or OpenOffice. The formatting was preserved in both settings when pasting from HTML.

ETA: Looks like my browser updated last night, so this test was actually with Firefox 70!

redsummernight
October 28, 2019, 1:18 AM

Environment: Firefox 70 on Windows 7.

The RTE on staging has all the surface features of the one on beta (same formatting options, HTML tree indicator at bottom left, vertical resize handle at bottom right).

Samples:

  • HTML file (master): all formatting preserved.

  • New testing document (Word 2013, Windows 7): behavior consistent with beta.

    • Blockquotes are lost.

    • RTL text direction is lost.

    • Table heading cells become normal cells with bold/center formatting.

Looks good.

DeployedToBeta

Assignee

Sarken

Reporter

Sarken

Roadmap

Misc

Priority

Medium

Affects versions

Fix versions

Components

FrontEnd

Difficulty

Medium

Milestone

Internal 0.9
Configure