Bookmarks: Language option missing from search and filter interface

Description

Example URLs
Bookmark Search page: https://test.archiveofourown.org/bookmarks/search
Bookmark tag page: https://test.archiveofourown.org/tags/Suits%20(TV)/bookmarks
User bookmark page: https://test.archiveofourown.org/users/testy/bookmarks
Collection bookmark page: https://test.archiveofourown.org/collections/yuletide/bookmarks

The problem

We index bookmarks based on the bookmarkable item's language, making it possible to search for bookmarks of works in another language, e.g. Russian:

  • In Elasticsearch 0.90, you can do this by entering bookmarkable_language_id: 30 in "Any field" on the Bookmark Search page, or in "Search within results" on a tag, user, or collection bookmark page

  • In Elasticsearch 6, you can do this by entering language_id: 30 in "Any field on work" on the Bookmark Search page, or in "Search within results" on a tag, user, or collection bookmark page

However, there's no way to select a language on either the filters or the search page.

The solution
On Elasticsearch 6 – no need to implement it on 0.90 – we should add a "Work language" select menu to both the filters and the search page.

  • On the filters, it should be between "Search bookmarker's tags and notes" and "Bookmark types" (to mirror its position of after the search field on work filters)

  • On the search page, it should be between "Bookmarker's tags" and the checkbox for "Rec"

    • If is implemented, it can be before or after the field for selecting the type

There should also be automated tests for these fields.

Notes
Only works – not series or external works – have languages set, so if you specify a language, the results will only be works.

Activity

Show:
Sarken
January 28, 2019, 10:42 PM

“Work language” is between “Type” and “Date updated” on https://test.archiveofourown.org/bookmarks/search, which is correct (AO3-5374 was implemented). Choosing español gets me only bookmarks of works in Spanish and displays “Work language: español” in the summary at the top of the search results page. Pressing “Edit Your Search” takes me back to the form with that language chosen.

On the filters for https://test.archiveofourown.org/tags/Sherlock (TV)/bookmarks “Work language” appears between "Search bookmarker's tags and notes" and "Bookmark types". Choosing “Deutsch” gets me only bookmarks of works in German. When I look at the filters, “Deutsch” is selected.

Looks good!

cosette
January 30, 2019, 3:37 AM
Lady Oscar
February 1, 2019, 6:35 AM

Looks good!

DeployedToBeta

Assignee

DreamSea

Reporter

Sarken

Roadmap

Bookmarks
Internationalization

Priority

Medium

Affects versions

Fix versions

Components

FrontEnd

Difficulty

Medium

Milestone

Internal 0.9