Purge IP addresses for Support tickets as soon as feasible

Description

When someone, logged in or out, submits a Support ticket, their IP is collected for spam prevention. It is stored in the database.

Support does not see or use the IP addresses. Ergo, if we could send them to the spam checker without saving them to the database, that would be ideal. If we cannot, IP addresses should be purged either daily or immediately after the ticket is created – whichever is feasible.

If we cannot drop the column, it will be necessary to purge IP addresses from all existing tickets.

Testing

Instructions will depend on the solution that is implemented.

Activity

Show:
tlee911
November 16, 2020, 5:43 AM
Edited

Seems this could be done just by adding attr_accessor :ip_address into models/feedback.rb turning that DB column unused. All rows will have null IP address from that point onwards, though the value will still get sent in Akismet attributes.

Then we can drop the column entirely in a subsequent DB migration (or right away, if we’re feeling adventurous).

Sarken
November 20, 2020, 2:39 PM

I think that should be okay. I remember an earlier discussion about storing user agent strings in order to spam check comments (AO3-3818) – we were hoping we could stop storing that, but it turned out we needed it so we could mark comments as spam if they weren’t caught in the initial check.

Support tickets, however, can’t be marked as spam after their initial creation, so I think we can get away without keeping the IP info.

Assignee

tlee911

Reporter

Sarken

Roadmap

Misc

Priority

High

Affects versions

Fix versions

None

Components

BackEnd

Difficulty

Medium

Epic Link

Milestone

Internal 0.9