Editing the tags on an external work to simultaneously add and remove a tag does not move the bookmark to the proper bookmark page if the new tag is a synonym or subtag

Description

  1. Log in as a user

  2. Create a new bookmark of an external work using a synonym of a canonical tag in at least one field

  3. Wait a few minutes and confirm it shows up on the bookmark listings for the canonical tag

  4. Log out

  5. Log in as admin

  6. Go to the tag listings, follow the link to the external work, and click on Edit External Work

  7. Click the "x" on the tag you added to remove it, fill in the field with a new syn of a different canonical tag, and save the changes

  8. Wait a few minutes

What happens:
The bookmark is removed from the bookmark listing for the old tag's canonical. It is not on the page for the new tag's canonical.

What should happen:
The bookmark should be in the new tag's listings.

Notes:
This has to be done with syns – it works fine if using canonicals. ticking instant's comment describes the issue in detail.

Activity

Show:
ticking instant
June 3, 2018, 1:51 AM

I believe it also fails with sub-tags now that the meta-tag code is merged. It should show up in the sub-tag's filter, but not the meta-tag's.

(And I don't think the first tag needs to be a syn – a canonical would also work. But the second does have to be a syn or a sub-tag, because the new indexing ensures that it'll always show up in any tag it's directly tagged with, regardless of whether the relevant FilterTagging exists.)

Sarken
April 26, 2020, 10:56 PM

With a syn:

  1. Created a new external work bookmark tagged with MASH, which is a syn of MASH (TV). It appeared in MASH (TV)'s bookmark listings.

  2. As an admin, edited the external work to change the fandom to Dallas TNT, which is a syn of Dallas (2012). The bookmark disappeared from MASH (TV) and appeared on the list for Dallas (2012).

Looks good!

With a subtag:

  1. Created a new external work bookmark tagged with Daredevil (2003), which is a subtag of Marvel. It appeared in the bookmark listings for both Daredevil (2003) and Marvel.

  2. Logged in as an admin and edited the external work to change the fandom to Birds of Prey (TV) which is a subtag of DCU. The bookmark disappeared from both the Marvel and Daredevil (2003) tags and appeared in the bookmarks for both Birds of Prey (TV) and DCU.

Looks good!

 

Tag Wrangler Chairs
May 15, 2020, 2:32 AM
Edited

Qem:

  1. Log in as a user

  2. Create a new bookmark of an external work using a synonym of a canonical tag in at least one field

Created a bookmark for “I'll/Generation Basket” which is a syn of “I'll | I'll Generation Basket

  1. Wait a few minutes and confirm it shows up on the bookmark listings for the canonical tag

done

  1. Log out

  2. Log in as admin

  3. Go to the tag listings, follow the link to the external work, and click on Edit External Work

  4. Click the "x" on the tag you added to remove it, fill in the field with a new syn of a different canonical tag, and save the changes

  5. Wait a few minutes

 

Removed “I’ll” and added “A Syn for Some Testing Fandom

 

Waited and confirmed that it shows up in testing bookmarks but not in I’ll bookmarks.

Assignee

ticking instant

Reporter

Sarken

Roadmap

Admin
Bookmarks

Priority

Low

Affects versions

Fix versions

Components

BackEnd

Difficulty

Medium

Required Access Level

Admin

Milestone

Internal 0.9
Configure