Remove admin setting for disabling filters
Description
Way back in 2012, we added an admin setting that would allow us to disable filtering in the event the move to Elasticsearch made the site blow up.
We'd like to remove this setting and all associated code now.
Testing
Log in as admin and check that "Turn off filtering on index pages" no longer appears on the settings page
Search the GitHub repo for "disable_filtering" and make sure you get zero results
Activity
Migration has been run:
ao3app@test-app12:~/app/current$ bundle exec rake db:migrate:up VERSION=20190323185300
== 20190323185300 DropDisableFilteringFromAdminSettings: migrating ============
-- remove_column(:admin_settings, :disable_filtering, :boolean, {:default=>false, :null=>false})
-> 0.1912s
== 20190323185300 DropDisableFilteringFromAdminSettings: migrated (0.1914s) ===
Logged in as an admin and it’s gone! disable_filtering is still in the repo, but only in the schema and structure files and the migration, so that’s fine!
Option no longer appears in the Settings page, I only see disable_filtering on the same places Sarken says they should be, so it looks fine!
Confirmed! And glad to have that event buried in the past....
