Marvel Is Broken: The Missing FilterTagging Reason

Description

Steps to reproduce

  1. Log in as a wrangler

  2. Create a canonical fandom tag "Metatag" (note: it doesn't have to be a fandom, but all tags must be canonical and of the same type)

  3. Create a canonical fandom tag "Subtag A" and add "Metatag" as its metatag

  4. Create a canonical fandom tag "Subtag of Subtag A" and add "Subtag A" as its metatag

  5. Create a canonical fandom tag "Subtag B" and add "Metatag" as its metatag

  6. Post a work that uses both "Subtag B" and "Subtag of Subtag A"

  7. Wait for listings to update and confirm the work appears in the listings for "Metatag," "Subtag A," and "Subtag of Subtag A."

  8. Edit the tag "Subtag of Subtag A" to remove "Subtag A" as a metatag

What happens

The work posted in step 6 should continue to be in the work listings for "Metatag" because it still has "Subtag B."

What happens

It is no longer included in the listings.

Notes

This is affecting a bunch of Marvel Cinematic Universe works. Info from ticking instant:

ticking instant [17:49]
I was poking around the Avengers tag to try to see how the new crossover code was doing, and I noticed that there's nearly 20,000 works tagged with "The Avengers (Marvel Movies)" that don't seem to have their inherited "Marvel" filter.

This isn't part of the previous bug, since "The Avengers (Marvel Movies)" still seems to have "Marvel" as a meta tag. (I checked a newly-posted work.)

It turns out that there's actually yet another bug related to removing meta tags, this one affecting the FilterTaggings instead of the MetaTaggings.

If you have an overarching meta tag (like "Marvel") with two sub tags (like "Thor - All Media Types" and "The Avengers (Marvel Movies)"), and a subtag of the first sub tag (like "Thor (Movies)"), and you delete the MetaTagging between "Thor - All Media Types" and "Thor (Movies)", then any work tagged with both "Thor (Movies)" and "The Avengers (Marvel Movies)" will have the "Marvel" filter removed.

As far as I can tell, this has happened a bunch of times with Marvel tags, including: "Iron Man (Movies)", "Thor (Movies)", "Guardians of the Galaxy (Movies)", "The Incredible Hulk (2008)", and even a couple of comics tags as well.

Between the two bugs, there are over 40,000 works in the "Marvel Cinematic Universe" tag that are missing the "Marvel" meta tag.

Note from Tag Wrangling about the structure of the Marvel tags:

The tag structure was:

  • Marvel

    • Marvel Cinematic Universe

      • Thor (Marvel Movies)

      • The Avengers (Marvel Movies)

    • Thor - All Media Types

      • Thor (Marvel Movies)

and is now:

  • Marvel

    • Marvel Cinematic Universe

      • Thor (Marvel Movies) (with Thor - All Media Types synned to it)

      • The Avengers (Marvel Movies)

This often happens alongside in production, as seen in Marvel fandoms. The issues can, however, occur separately. (According to ticking, there are over 40,000 works in the "Marvel Cinematic Universe" tag that are missing the "Marvel" metatag, and 5508 accounts for about 13,000 of those.)

This is not super high priority as we are eyeing a rewrite of this code. However, it's good to have these things logged.

Assignee

ticking instant

Reporter

Sarken

Roadmap

Tag Wrangling

Priority

Medium

Affects versions

None

Fix versions

Components

BackEnd

Difficulty

Medium

Required Access Level

Tag Wrangler

Milestone

Internal 0.9
Configure