When orphan_account is a co-creator on a multi-chapter work, subscription emails are sent when the other co-creator posts a chapter that does not list orphan_account as a creator

Description

Steps to reproduce

  1. Log in

  2. Hi, username! > My Dashboard

  3. Make sure you are not subscribed to your own account (in other words, press "Unsubscribe" if it appears)

  4. Go to the orphan_account's dashboard

  5. Press "Subscribe"

  6. Post > New Work

  7. Fill in required information

  8. Check "Add co-creators?"

  9. Enter "orphan_account (orphan_account)"

  10. Press "Post Without Preview"

  11. Have a database admin send subscription notifications (bundle exec rake notifications:deliver_subscriptions) or wait for them to send (note that notifications will not be sent for the work you just posted)

  12. Follow "Add Chapter"

  13. Fill in required information

  14. Do not add orphan_account as a co-creator on the chapter

  15. Press "Post Without Preview"

  16. Have a database admin send subscription notifications (bundle exec rake notifications:deliver_subscriptions) or wait for them to send

What happens

You get a subscription email because you are subscribed to orphan_account.

What should happen

In an ideal world where AO3-3620 was fixed, getting a subscription email would actually be the desired result! (I think. If you're subscribed to User A, who has co-created a work with User B, and User B posts a chapter to that work without User A as a co-creator, should you get an email? I assume yes.)

However, assuming we are not in that ideal world, following the steps above should result in no email being sent. We like things equally broken.

We mostly want this fixed because people are confused why they’re getting these emails. They always turn out to be subscribed to the orphan_account, but they’re not used to getting emails due to AO3-3620.

Notes

We check if orphan_account is a co-creator on the creation, but I think we need to check if orphan_account is a co-creator on the work in the event the creation is a chapter.

Also note this doesn't happen with series – that is, people who are subscribed to orphan_account do not get an email if someone posts a work to a series orphan_account has co-created.

 

Environment

None

Status

Assignee

Unassigned

Reporter

Sarken

Roadmap

Works

Priority

Medium

Affects versions

Fix versions

None

Components

BackEnd

Difficulty

Medium

Required Access Level

None

Milestone

Internal 0.9
Configure