Gift Exchange: My Assignments page has email link when user has multiple assignments in an exchange

Description

Steps to reproduce

  1. Log in

  2. Create a collection with a gift exchange challenge

    1. Browse > Collections > New Collection

    2. Fill in required information and choose "Gift Exchange" for "Type of challenge, if any"

    3. Submit

    4. On the exchange settings form, check "Sign-up open?"

    5. Submit

  3. Sign up for the exchange as at least three different users

    1. Follow the "Sign-up Form" link in the collection sidebar

    2. Since we accepted the default settings, we don't even need to fill anything in – just press "Submit"

  4. If you're not already logged in as the collection owner, log back in with that account

  5. Run matching

    1. On your collection's sidebar, follow the "Challenge Settings" link

    2. Uncheck "Sign-up open?"

    3. Press "Update"

    4. From the sidebar, follow the "Matching" link

    5. Press "Generate Potential Matches"

    6. You'll get a pop-up warning you matches will be random; choose "OK"

    7. Wait briefly for matching to finish and refresh the page to see potential matches

  6. Send assignments

    1. Press "Send Assignments"

    2. You'll get a pop-up telling you assignments will be send; choose "OK"

  7. Default an assignment

    1. Follow the button-style "Open" link to see all open assignments

    2. Decide which user you want to double-assign, and check the "Default" option for the assignment that does not have that user as the recipient or giver

    3. Press "Submit"

  8. Double-assign the user

    1. You'll be on the Defaulted assignments page now!

    2. In the input field, enter the name of the person you want to double assign – you may need to enter it in the format "pseud (username)" due to

    3. Press "Submit"

  9. Log in as the double-assigned user

  10. Go to the collection page

  11. Follow the "My Assignments" link in the sidebar

What happens

Because you have multiple assignments in this challenge, you see a different page than you'd see if you only had one assignment. It's based off the page moderators see and includes an envelope icon which will allow you to email your recipient yourself, it turns out.

What should happen

That icon should not be there.

Notes

This is marked Highest because, when combined with AO3-5748, someone else’s email address may be displayed.

Testing notes

You can just log in as testy and make sure there is no longer an email link on the My Assignments page: https://test.archiveofourown.org/users/testy/assignments?collection_id=AO3_5748

ETA: Nope! You’ll have to log in as testy2 (or testy3) and put the correct username in this URL: https://test.archiveofourown.org/users/USERNAME/assignments?collection_id=AO3_5748. testy is a mod, so the email links will show up for them.

There should still be email links on the Assignments page for a moderator (log in as testy to check this page): https://test.archiveofourown.org/collections/AO3_5748/assignments?unfulfilled=true

Environment

None

Status

Assignee

enigel lj

Reporter

Sarken

Roadmap

Challenges

Priority

Highest

Affects versions

0.9.252

Fix versions

Components

FrontEnd

Difficulty

Easy

Required Access Level

None

Milestone

Internal 0.9