When showing hidden tags (both warnings/additional tags) the revealed links go to the tag page rather than the works page

Description

  • View a work and click on a tag

  • The link will go to the /tags/TAG/works page for that tag

  • Go to preferences and turn on hide warnings/hide additional tags

  • View the work and show the hidden tags and click on one

  • The link will go to the /tags/TAG page instead

Never-hidden tags all still go to the /works page.

This should be a quick fix in the show_hidden_tags_link method which is only used for this purpose and can safely be changed to make the url point to a tag's works rather than directly to the tag.

Activity

Show:
Stephen Burrows
April 10, 2020, 11:34 PM

Testing instructions:

  1. View a work and click on a warning / freeform tag

  2. The link will go to the /tags/TAG/works page for that tag

  3. View a work list page (like Browse > works) and click on a warning / freeform tag

  4. The link will go to the /tags/TAG/works page for that tag

  5. Go to preferences and turn on hide warnings/hide additional tags

  6. View the work and show the hidden tags and click on one

  7. The link should go to the /tags/TAG/works page for that tag

  8. View a work list page (like Browse > works) and show the hidden tags and click on one

  9. The link should go to the /tags/TAG/works page for that tag

 

Stephen Burrows
April 10, 2020, 11:36 PM

Comment for the release notes: Made links for tags revealed via “Show warnings” and “Show additional tags” go to the tag works page instead of the tag detail page.

Sarken
June 29, 2020, 5:14 AM

Set my preferences to hide warnings and freeform by default, went to the works page for the Testing tag, found a work with both warnings and freeforms, clicked the expand links. Warning link took me to the works page for the warning, and the freeform link took me to the works page for the freeform.

When I turned the preferences off, the tags were visible by default and the links continued to go to the works pages.

Looks good!

QED
June 29, 2020, 7:59 AM

Checked first warnings and freeforms without preferences set on hiding, everything was visible by default and links sent me to correct pages.

Changed preferences, went to works page of Soccer | Football tag, found a work with both warnings and freeforms, clicked the expand links. The warning link took me to works page with that warning, and the freeform link took me to works page with that freeform.

Switched back the preferences, the warnings and freeforms were visible by default, and all links sent me to correct pages.

Looks all good to me!

DeployedToBeta

Assignee

Stephen Burrows

Reporter

shalotta

Roadmap

Tags

Priority

Medium

Affects versions

Fix versions

Components

FrontEnd

Difficulty

Easy

Milestone

Internal 0.9
Configure