500 error when trying to access the list of tags in a tag set used by a gift exchange

Description

Steps to reproduce

First, create a tag set with more than 20 tags of one type, e.g. 21 characters:

  1. Log in

  2. Browse > Tags > Tag Sets > New Tag Set

  3. Fill in a title

  4. Enter more than 20 tags of one type in the appropriate field, e.g. 21 characters in the "Add Characters" field

  5. Press "Submit"

Second, create a gift exchange that uses the tag set and is open for sign-ups:

  1. Browse > Collections > New Collection

  2. Fill in required informat

  3. For "Type of challenge, if any," choose "Gift Exchange"

  4. Press "Submit"

  5. Check "Sign-up open?"

  6. Make sure the type of tag you used in your tag set is allowed in requests or offers, e.g. if your tag set uses character tags, you should be allowed to request at least one Character

  7. In "Tag Sets To Use," fill in the name of the tag set you created

  8. Press "Submit"

Now try to access the list of available tags:

  1. Follow the "Sign-up Form" link in the sidebar

  2. Use the "List [X] [Tag Type]" link

What happens

A 500 error:

What should happen

It should work.

Activity

Show:
Sarken
October 9, 2019, 11:21 PM

Surprise! Already has a fix in another PR:

The error is tag_type instead of @tag_type on current line 3

/home/ao3app/app/releases/20191009182403/app/views/owned_tag_sets/show_options.html.erb:3:in `block in _app_views_owned_tag_sets_show_options_html_erb___3214890490530188503_46983882745600'

which is now line 12 and uses @tag_type

redsummernight
October 19, 2019, 4:29 AM
Edited

Looks good.

Lady Oscar
October 24, 2019, 7:37 PM

Confirmed! Tried with a prompt meme, for fun, also worked.

DeployedToBeta

Assignee

Sarken

Reporter

Sarken

Roadmap

Tag Sets

Priority

High

Affects versions

Fix versions

Components

BackEnd
Caching

Difficulty

Medium

Milestone

Internal 0.9
Configure