Working with Translation to get Phrase (formerly PhraseApp) ready for them to start on translating the emails. Issue will be updated to reflect reality and what needs testing as we get farther along, but for now:
Create a new project on Phrase, which will mean updating the .phraseapp.yml config.
Restore all of the locale files Translation intends to use to their original, pre-messing-about-on-Phrase state by manually replacing them with the files from rails-i18n.
Remove any locale files not on Translation's list so they won't get loaded into Phrase and clutter things up. If Translation wants to add a new locale at a later date, the appropriate locale file from rails-i18n can be manually copied and added to the config/locales/defaults folder in our repo.
Organize the locale files into folders, and update config/application.rb so we can handle said structure.
Also update available_locales in config/application.rb to match Translation’s requested locales.
Translation’s requested locales: af, ar, bg, bn, ca, cs, cy, da, de, el, es, fa, fi, fr, he, hi, hr, hu, id, it, ja, ka, ko, lt, lv, mk, mr-IN, ms, nb, pl, pt-BR, pt-PT, ro, ru, sk, sl, sr, sv, th, tl, tr, uk, vi, zh-CN
This will primarily affect Translation and their use of Phrase, but because we’re moving locales to nested folders, let’s do a smoke test to make sure the locale files are getting loaded.
Log in, post a work, and then delete the work. You should get an email about the work being deleted and it should look normal, i.e. not say “translation missing.”
Make an unsuccessful attempt to log in as an admin, e.g. by entering the wrong username. You should get a blue flash error message and not, say, a 500 page or some text saying “translation missing.”
Test AO3-5113 and observe the bug (confusing error message) has changed.
Tested AO3-5113: the confusing message is now "Password confirmation doesn't match Password". The new default en locale file works.
Attempted a bad admin login: the red error message says "The password or admin user name you entered doesn't match our records." The Devise en locale file works.
Can't test emails, I'm not getting any from staging yet (I activated my account via Rails' console).
1) Logged in, posted a work, then deleted it.
Deleted work email looks normal and the same as Production's. (testy doesn't seem to be getting his email to the ML from Staging, but email to my account worked)
2) Tried logging in as admin, got the same message as redsummernight did.
3) Also tested and got the same confusing message as redsummernight.