Drop approved column on Feedbacks table

Description

For support tickets, we currently have an "approved" column that saves whether the ticket has been marked as ham (true) or spam (false). We don't do this for abuse reports, and there's no real reason to do it here. We can just run the report through the spam checker and send or reject it based on the results without saving said results to the database.

How to test the Support form: make sure you can still send a Support ticket. Also try sending one with the email field set to akismet-guaranteed-spam@example.com, and make sure that ticket still gets rejected as spam.

How to test the migration:
1. Run the migration.
2. Copy the commands that it prints to a file.
3. Run the pt-online-schema-change command (but no SQL commands).
4. Submit a new support request.
5. Count the number of rows in feedbacks.
6. Run the SQL commands to swap the tables and drop the old table.
7. Count the number of rows in feedbacks, and make sure it's the same as before.
8. Double-check to make sure that the approved column has been dropped.

Activity

Show:
james_
March 2, 2020, 10:29 PM

Created feedback, email received.

 

 

 

james_
March 2, 2020, 10:29 PM

 

 

ticking instant
March 3, 2020, 12:53 AM

Looks like it mostly ran successfully! But where did the second _feedbacks_old table come from? Did you keep it intentionally to be able to compare? Or is there something wrong with the pt-online-schema-change flags?

Also, do you want me to submit a PR to modify this migration to add the --ask-pass argument, too? Or is the plan to only add it for future migrations, and just add it manually when this migration has to be run?

james_
March 3, 2020, 8:45 AM

_feedbacks_old” I think this turned up because I did a rollback. Or maybe I didn't clean up properly

 

If you have time to add the --ask-pass then that would be nice but its not blocking. It just means I am less likly to get it wrong.

Sarken
March 4, 2020, 8:32 AM

--ask-pass has been added and merged and deployed to staging, fwiw

DeployedToBeta

Assignee

ticking instant

Reporter

Sarken

Roadmap

Misc

Priority

Low

Affects versions

Fix versions

Components

BackEnd

Difficulty

Easy

Required Access Level

Support

Milestone

Internal 0.9
Configure