Twitter share button not visible in Chrome and Firefox

Description

Steps to reproduce:

  1. Go to a work.

  2. Select the "Share" button to open the modal with the share options. (If the work doesn't have a "Share" button, the creator has likely disabled it. Try another work by another creator.)

What happens:

In Safari on Mac or iOS , or Chrome or Firefox on iOS, the Twitter share button is visible, as expected.

If you are on Chrome or Firefox on a Mac or Android device, there is an empty bullet point where the Twitter share button should be.

Tested on macOS 10.14 and 10.15 and iOS 12 and 13. Android version unknown. Results on Windows also unknown.

What should happen:

The button should be visible in all browsers.

Additional info:

In the browsers where it is invisible, the iframe width and height attributes are set to 1px:

In browsers where it is visible, the iframe width and height attributes are set to 76px and 28px respectively:

This appears to be related to the way Twitter's JavaScript interacts with the Twitter link being in a modal. Placing the link outside the modal ensures it is correctly visible (but we want it to stay in the modal, of course).

Activity

Show:
Rebecca Sentance
January 20, 2020, 10:08 AM

Tested on Firefox for Android and Firefox for Windows desktop and the button is there 👍 But no button appears when testing on Chrome with Windows desktop.

 

Sarken
January 21, 2020, 1:50 AM

I’m going to have to amend my comment. Sometimes in Chrome, the Twitter button isn’t there where I first click the Share button. It does generally show up if I close the modal and then click the button a second time, though. That’s also true on production.

It does seem more likely to load on the first try on staging, but it still doesn’t always do so.

Sarken
January 21, 2020, 9:23 PM

We tweaked it to help with the Chrome on Windows case and:

nimadge 10 hours ago
I have it on Windows 10 Chrome (edited)

nimadge 10 hours ago
Also in staging on Android Chrome. There is no tumblr button, but the area is active and working, just doesn't have the image or smth

Rebecca Sentance 9 hours ago
I have both buttons on Windows 10, Chrome!

Rebecca Sentance 9 hours ago
They also both appear on Chrome for Android :3

C. Ryan Smith and MagnusIsMyRock should also get testing credit because they helped confirm the initial report of the issue on Chrome and then helped me test the fix via skins.

Jennifer Davis
September 2, 2020, 10:44 PM

This is also true for the Share button on bookmarks (not visible in Firefox at least).

redsummernight
September 7, 2020, 9:32 PM

@Jennifer: in recent Firefox versions you may have to turn off "Enhance Tracking Protection" for the Tweet button to show up. Also this issue has been closed, you shouldn't discuss possible new bugs here.

DeployedToBeta

Assignee

Daniel Erenrich

Reporter

Sarken

Roadmap

Misc

Priority

Medium

Affects versions

Fix versions

Components

FrontEnd

Difficulty

Medium

Milestone

Internal 0.9
Configure