Currently, the "Share" button on work pages is set up so that all of the sharing options are rendered and embedded in the work page, and the "Share" button just shows them (without performing another HTTP request). This means that:
The server is performing unnecessary work for any user who views the work page and doesn't press the "Share" button.
The twitter and tumblr buttons included in the sharing options mean that the user sends an HTTP request with AO3 listed as the referrer () to both twitter and tumblr when they view a work.
It would be good to move the sharing options off of the work page and into their own controller, to be loaded dynamically when the user presses the "Share" button.
Testing Instructions: Make sure that you can still use the "Share" button on works.
Release notes comment: Improved user privacy by limiting HTTP requests to third party sites on works pages.
Verify in Developer Tools > Network Traffic that loading a work detail page does not cause any http requests to twitter or tumblr.
Verify that visiting the share URL (/works/:id/share) for a work in an unrevealed collection does not give away any information about the work.
View a work that can be shared as a logged-out user, open the share modal, close the share modal, and log in. Verify that after login you are viewing the work.
View a multi-chapter work and verify that the "share" button works
Tested all of the above scenarios, and this works as expected except for #5.
I can confirm that adding a work to an unrevealed collection does remove the Share button.
1 - 5 ok.
open dialog, close dialog log in go to page https://test.archiveofourown.org/users/zz9pzza however pressing the share button makes no change it does the same even if I don’t do that
Happy that 7 works.
6 does the same for me on beta so I think that is ok