Still can't accept the Terms of Service in the GDPR prompt in some very old versions of Safari

Description

If you attempt to access the site in a private window in Safari 9.x or earlier on a Mac, or in a private window in Safari on iOS 9 or earlier, you will get the GDPR prompt asking you to agree to the Terms of Service. However, checking the box and clicking the button to accept does not make the prompt go away.

The following error appears in the JavaScript console after clicking the button:

QuotaExceededError: DOM Exception 22: An attempt was made to add something to storage that exceeded the quota.

We’re just going to give up on the idea of overriding window.localStorage for browsers that don’t support it correctly and instead just check whether it works and, if not, create a cookie some less convoluted way.

Testing

Please note what browser version, OS version, and device you’re using to test.

  1. Open a private window in one of the listed browsers.

  2. Go to https://test.archiveofourown.org

  3. When the TOS prompt appears, check the box and press the accept button.

  4. Ensure it goes away and stays away if you navigate to another page while in the same tab.

  5. Close the private window.

  6. Open a new private window in one of the listed browsers.

  7. Go to https://test.archiveofourown.org?tos=yes

  8. Ensure the TOS prompt does not appear and that it does not appear when you navigate to another page while in the same tab.

It is also a good idea to make sure that the TOS prompt works correctly in other browsers, both when using the ?tos=yes parameters (these should prevent the prompt from ever appearing) and when not using them.

Assignee

teyla

Reporter

Sarken

Roadmap

Visitors

Priority

Highest

Affects versions

Fix versions

Components

FrontEnd

Difficulty

Medium

Milestone

Internal 0.9
Configure