Links in bookmark blurb stats lines have their bottom borders (faux underline) cut off

Description

Steps to reproduce

  1. Log in using the browser of your choice on Windows

  2. Find and bookmark a work that has some links in its stats line (i.e. has kudos, collections, comments, multiple chapters)

  3. Go to your bookmarks page

What happens

The bottom borders/faux underlines on any links in the last line of the work's stats are hidden.

What should happen

It should be visible.

Notes

If you look at the CSS for the section of the bookmark that contains your notes (.bookmark .user) – the user module – you'll see there's a margin-top: 0.643em on it. However, this margin doesn't actually work because the stats line was floated in (pull request #1139).

Ergo, we probably need to add margin-bottom: 0.643em to .bookmark .blurb dl.stats to create the desired margin. (When you press "Edit" on a bookmark, the margin-top adds a tiny bit of space between the bottom of the edit form and the user module, so it should probably stay in despite being mostly useless.)

This issue happens on Windows but not Mac due to the font difference described in AO3-5526. However, there is very little space between the links' borders and the user module.

Activity

Show:
Sarken
June 5, 2020, 5:31 AM

In Edge 83 on Windows 10 via Browserstack, the underline was no longer cut off.

No new issues in Safari 13.1 on Mac OS 10.15.4, either.

cosette
June 8, 2020, 6:47 PM
Edited

the borders are no longer cut off when viewing bookmarks in IE and chrome on windows 10 (and chrome/safari/opera on OS X 10). looks good.

mumble
June 13, 2020, 9:09 PM

Can confirm no underlines on bookmark stat links in Firefox 77.0.1 on Windows 10 on production (if it’s the only or last line), and happy underlines on staging. Fixed! \o/ (On Safari/iPhone, underlines are present on both production and staging.)

Assignee

cosette

Reporter

Sarken

Roadmap

Bookmarks

Priority

Medium

Affects versions

Fix versions

Components

FrontEnd

Difficulty

Easy

Milestone

Internal 0.9
Configure