Make "Update Tag Filters" troubleshooting option work for unfilterable tags

Description

The "Update Tag Filters" troubleshooting option (available only to admins) uses Tag#synonyms, which generates an error if the tag is not canonical and doesn't have a merger. It should use Tag#mergers instead, to make sure that it works for all tags.

Testing Instructions

  1. Log in as admin.

  2. Find a tag that's not canonical and has no synonym set.

  3. Go to the tag's Troubleshoot page.

  4. Check the "Update Tag Filters" option.

  5. Press "Troubleshoot."

  6. Make sure that it returns a success notice, instead of a 500 error.

Activity

Show:
james_
June 22, 2020, 7:11 PM
Edited

For the next tester use

james_
June 22, 2020, 7:13 PM

 

went to https://test.archiveofourown.org/tags/High High High - Fandom pressed troubleshoot

Clicked all the buttons, seemed happy

Looks good to me

Ehryn (Danielle Strong)
June 27, 2020, 9:50 AM

I tested using the tag ‘DVR’ which didn’t appear to have any syns and didn’t seem to be Canonical. After following the steps, it successfully returned “Tagged items enqueued for filter updates.” instead of a 500 error.

DeployedToBeta

Assignee

ticking instant

Reporter

ticking instant

Roadmap

Tag Wrangling

Priority

Medium

Affects versions

Fix versions

Components

BackEnd

Difficulty

Medium

Required Access Level

Admin

Milestone

Internal 0.9
Configure