Update comment factories to better resemble valid Archive comments

Description

Our comment factories have two issues that make them inconsistent with how comments on the Archive function:

  1. They create comments that are simultaneously from registered users and guests, which is not how Archive comments typically function.

    1. For the comment, unreviewed_comment, and adminpost_comment factories, they should either have a name and email (making them guest comments) or belong to a pseud, not both. This may ultimately require the creation of separate factories for logged in comments and guests. (A guest_comment factory for works will be introduced in the pull request for AO3-5765.)

    2. For the tag_comment factory, they should only belong to registered users, as only tag wranglers can comment on tags.

  2. The comment factory and unreviewed_comment factory assign the comments to works, but comments are actually on chapters, not works.

    1. This may be causing an issue mentioned in a Cucumber step definition. If possible, this step should be updated to use the factories.

If updating the factories results in any test failures, the tests should be updated as well.

DeployedToBeta

Assignee

ticking instant

Reporter

Sarken

Roadmap

Comments

Priority

Medium

Affects versions

Fix versions

Components

AutomatedTests

Difficulty

Easy

Milestone

Internal 0.9
Configure