Series page for a pseud does not indicate which pseud it belongs to or how many series it contains

Description

Steps to reproduce

  1. Log in

  2. Hi, username! > My Preferences > Manage My Pseuds > New Pseud

  3. Fill in the "Name" field with the pseud you want to make, e.g. "testy2"

  4. Press "Create"

  5. Post > New Work

  6. Fill in form, choosing the pseud you just created and making sure to add the work to a series

  7. Post

  8. Your pseud will be included in the byline of the work – follow the link to access your pseud

  9. Now follow the Series link in the dashboard

What happens

The h2 says "username's Series."

What should happen

It should say "X Series by pseud (username)" to more clearly indicate which series page you are on, and to better match the headings on pseuds' /works and /bookmarks pages, which say things like "X Bookmarks by pseud (username)."

The exception to this is if you're on the pseud series page that matches the username, e.g. https://test.archiveofourown.org/users/testy/pseuds/testy/series should say "X Series by testy," not "X Series by testy (testy)."

If we'd prefer it use "X Series by testy (testy)," we would also want to update what is used on the /works and /bookmarks pages, and the dashboard, if is implemented before this.

Activity

Show:
Sarken
August 16, 2020, 3:02 PM

The no counts version is indeed the desired version – the Series page doesn’t currently have a count in the header, so we can continue to live without it.

ticking instant
August 17, 2020, 2:39 AM

If you do want to add counts, a less hacky way of handling it might be to replace collection.size with collection.total_entries in the search_header function.

Sarken
November 10, 2020, 1:46 PM

My user series page says “7 Series by sarken” and my pseud’s series page says “2 Series by sarks (sarken).” The counts are correct in both cases.

Looks good!

lydia-theda
November 10, 2020, 2:05 PM

Tried both posting a work into a new series and editing a work into an existing series not originally owned by that pseud – pseud’s series increased both times, current count is accurate. Looks good

Sarken
November 10, 2020, 2:42 PM

In Slack, lydia-theda also confirms “the header showed the correct # Series by pseud (username)”

DeployedToBeta

Assignee

tlee911

Reporter

Sarken

Roadmap

Pseuds
Series

Priority

Medium

Affects versions

Fix versions

Components

FrontEnd

Difficulty

Easy

Milestone

Internal 0.9