Remove anon_commenting_disabled column from the works table, and remove associated code
Description
Now that the code for disabling comments is live (), we want to clean up all the code pertaining to the old anon_commenting_disabled column, and create a migration to remove the column.
Notes: Because this is a migration on the works table, it should use pt-online-schema-change to avoid downtime. And because we're deleting a column, we should use ignored_columns= to prevent errors during/after the migration.
Deploy Steps
Wait for all workers/unicorns to restart completely, so that everything is running the new code.
Run the migration to remove the column.
Test Steps
Wait for the migration to run.
Check that you can still enable/disable anonymous comments on the normal works form.
Check that you can still enable/disable anonymous comments on the Edit Multiple Works form.
Verify that you can use the Edit Multiple Works form to turn off moderated commenting.
Verify that you can use the Edit Multiple Works form to make a restricted work unrestricted.
Activity
Migration ran well
Issue ready for testing
I can still enable/disable anonymous comments on the normal works form ("Registered users and guests can comment" vs "Only registered users can comment").
Using the Edit Multiple Works form, I can:
enable/disable anonymous comments
turn on/off moderated commenting
make a restricted work unrestricted (Visibility > Show to all).
Looks good.
I could still turn guest commenting off and on again on a single work
I could turn guest commenting off and then back on on two works using Edit Multiple works… but weirdly, when I accessed the works as a guest, only one of them had the form re-enabled. (It’s caching, of course, because the work’s edit page shows the correct setting, but it was odd that just one work had this issue. The only reason I mention this is turning guest commenting on and off on a single work appeared to update the cache, which seemed weird in and of itself.)
I could turn comment moderation on and off on two works using Edit Multiple works. (The logged out/cached copies of the works did not update, but the logged in versions did.)
I could make two restricted works unrestricted using the Edit Multiple form.
Looks good!
