Remove anon_commenting_disabled column from the works table, and remove associated code

Description

Now that the code for disabling comments is live (), we want to clean up all the code pertaining to the old anon_commenting_disabled column, and create a migration to remove the column.

Notes: Because this is a migration on the works table, it should use pt-online-schema-change to avoid downtime. And because we're deleting a column, we should use ignored_columns= to prevent errors during/after the migration.

Deploy Steps

  1. Wait for all workers/unicorns to restart completely, so that everything is running the new code.

  2. Run the migration to remove the column.

Test Steps

  1. Wait for the migration to run.

  2. Check that you can still enable/disable anonymous comments on the normal works form.

  3. Check that you can still enable/disable anonymous comments on the Edit Multiple Works form.

  4. Verify that you can use the Edit Multiple Works form to turn off moderated commenting.

  5. Verify that you can use the Edit Multiple Works form to make a restricted work unrestricted.

Activity

Show:
james_
October 7, 2020, 9:00 AM

 

Migration ran well

james_
October 7, 2020, 9:01 AM

Issue ready for testing

redsummernight
October 11, 2020, 7:19 AM
  • I can still enable/disable anonymous comments on the normal works form ("Registered users and guests can comment" vs "Only registered users can comment").

  • Using the Edit Multiple Works form, I can:

    • enable/disable anonymous comments

    • turn on/off moderated commenting

    • make a restricted work unrestricted (Visibility > Show to all).

Looks good.

Sarken
October 12, 2020, 4:33 PM
  • I could still turn guest commenting off and on again on a single work

  • I could turn guest commenting off and then back on on two works using Edit Multiple works… but weirdly, when I accessed the works as a guest, only one of them had the form re-enabled. (It’s caching, of course, because the work’s edit page shows the correct setting, but it was odd that just one work had this issue. The only reason I mention this is turning guest commenting on and off on a single work appeared to update the cache, which seemed weird in and of itself.)

  • I could turn comment moderation on and off on two works using Edit Multiple works. (The logged out/cached copies of the works did not update, but the logged in versions did.)

  • I could make two restricted works unrestricted using the Edit Multiple form.

Looks good!

DeployedToBeta

Assignee

ticking instant

Reporter

ticking instant

Roadmap

Comments

Priority

Medium

Affects versions

Fix versions

Components

BackEnd

Difficulty

Medium

Milestone

Internal 0.9