Use remote links to show more kudos at the bottom of the works page, instead of CSS

Description

Currently, the #kudos element at the bottom of works contains a list of all users who have ever given kudos to the work. In AO3-2176, the wall of kudos was hidden using CSS, but the list is still there in the source, even though only the first 50 are shown. At ~40-50 bytes per kudo, that can in some cases result in a kudos list that is multiple megabytes.

Let's change that. The work page should only list the first 50 kudos, and the link to show more kudos should be a remote link that retrieves a list of kudos from the server, instead of the source.

Testing Instructions:

  1. Find a work on the test servers with a large number of kudos.

  2. View the kudos list at the bottom.

  3. Click on the "and X more users" link.

  4. It should load some more user names, but not all of them. At the end of the list of kudos loaded, there should be another "and X more users" link. The number in the link should have decreased by 50.

  5. Click on the new "and X more users" link to make sure it behaves as expected, too.

  6. Go to the /works/ID/kudos page for the same work. Make sure that it's only showing the first 50 kudos, and that the page links to show more kudos seem to be working properly.

Activity

Show:
redsummernight
January 21, 2021, 1:56 PM
Edited

https://test.archiveofourown.org/works/494729/kudos shows 24 pages, which would fit with 1173 users at 50/page. Interestingly, it’s in reverse order from the kudos list on the main works page, which seems backwards.

The change was deliberate, so someone going through the pages one-by-one won't see duplicates as new kudos are added.

Rebecca Sentance
January 22, 2021, 7:56 AM

Everything seems to work as expected! Tested on Firefox for Windows 10.

Sarken
January 22, 2021, 3:53 PM

After some discussion, we decided to switch the order of the kudos on the /kudos page – they’ll now go from newest to oldest, as they do on the bottom of the work, to avoid people expecting to see their kudos on the first page and getting confused when it’s not there.

That change is merged and ready for testing.

lydia-theda
January 23, 2021, 2:18 AM

It is newest to oldest now; /kudos page 1 shows the same 50 names that appear initially on the work page. Leaving kudos (either in another tab or as someone else) while flipping through the pages pushes a name from the previous page to the next page.

Sarken
January 25, 2021, 4:00 PM

With JavaScript enabled, I could eventually load all the kudos on https://test.archiveofourown.org/works/555307 using the “x more users” link. (Good lord, why would you want to, though?) The value of x updated with each page loaded.

I noticed that if I left kudos after loading all the names, it collapsed again, which doesn’t seem ideal, but we can live with it at least for the time being.

With JavaScript disabled, “x more users” instead took me to the /kudos page, which listed kudos in the same order as the bottom of the work, 50 kudos at a time. Navigating through the pages worked as expected. I didn’t notice any display issues when I checked on a smaller screen.

Looks good!

DeployedToBeta

Assignee

ticking instant

Reporter

ticking instant

Roadmap

Misc

Priority

Medium

Affects versions

Fix versions

Components

BackEnd

Difficulty

Medium

Milestone

Internal 0.9