Update autocomplete to treat pipes (|) as delimiters
Description
Attachments
Activity
Sarken April 15, 2025 at 4:12 AM
I got basically the same results as choux above: everything checkout out, but there was a definite difference between “Queen Regina” and “Queen | Regina”, with the piped version taking noticeably longer, but not that much longer. Maybe 1.5 seconds vs 1 second, compared to a much bigger difference on production (like 5+ seconds for the piped version vs near-instant for the unpiped).
Looks good!
choux April 14, 2025 at 12:40 AM(edited)
Tried searching only “|” to no results, then typed in various characters that had a pipe to their name while timing it with a stopwatch. They all took less than a second, although the “[NAME] [2ND NAME]” and “[NAME] | [2ND NAME]” formats took a fraction longer, but still less than a second.
all good from my end!
Bilka March 20, 2025 at 12:25 PM
Issue updated with the notes below, thank you !
slavalamp March 20, 2025 at 2:32 AM(edited)
Testing:
Open the Post new work page, go to the Relationship form
Try inputting “|” (a single vertical bar) - it should say “No suggestions found”
Try inputting words only separated by a bar with no spaces, e.g. “Taylor|Skitter“ - it should get some suggestions
Take a search query that has a vertical bar or multiple, e.g. a character tag like “Taylor Hebert | Skitter | Weaver“
First try inputting it with the bars removed (“Taylor Hebert Skitter Weaver“), note how long it takes to show suggestions (probably less than a second)
Try inputting it with the bars present, it should take a similar time to search and not weirdly long (ignore the “&;” in the results if there’s any, that’s a different issue that i’m solving next)
Do the same for some other query to make sure it’s consistent
slavalamp March 19, 2025 at 11:55 PM
Clarifications:
Increased response times happen when pipes are surrounded by other delimiter characters like spaces, so “taylor hebert | skitter” takes longer than “taylor hebert skitter” or “taylor hebert|skitter”
Compared to requests without pipes, the response times are generally up from 3 times longer for fandoms, 5+ for characters and freeforms, 15+ for relationships, and 30+ for all-tag search, which is at least several seconds of delay and really noticeable
noticed that adding pipes (without spaces in particular) to search messes with autocomplete results, as shown in the attached screenshot.
Additionally, folks have observed that adding more pipes (surrounded by other delimiter characters like spaces) can result in increased response times for the autocomplete popup, depending on how many pipes are in the inputted text. So “taylor hebert | skitter” takes longer than “taylor hebert skitter” or “taylor hebert|skitter”. Compared to requests without pipes, the response times are generally up from 3 times longer for fandoms, 5+ for characters and freeforms, 15+ for relationships, and 30+ for all-tag search, which is at least several seconds of delay and really noticeable.
We should be able to add the pipe character to the list of delimiters (characters used to split phrases) here to resolve these issues.
Testing
Open the Post new work page, do the following in the “Relationship” field:
Try inputting “|” (a single pipe) - the autocomplete should say “No suggestions found”
Try inputting words only separated by a bar with no spaces, e.g. “Taylor|Skitter“ - it should result in some autocomplete suggestions
Take a search query that has a pipe or multiple, e.g. a character tag like “Taylor Hebert | Skitter | Weaver“
First try inputting it with the bars removed (“Taylor Hebert Skitter Weaver“), note how long it takes to show autocomplete suggestions (probably less than a second)
Try inputting it with the bars present, it should take a similar time to search and not weirdly long. If “&;” shows up in the search results, you can ignore it, that’s a different bug
Repeat step 4 for another different tag to make sure it’s consistent