Removing a work's fandom and pressing Cancel on the error page saves the work without a fandom
Description
Steps to reproduce:
Edit an existing work to remove its fandom and press Post.
Thanks to the fix in AO3-4808, an error message appears telling you the work is invalid because there is no fandom.
However, if you press Cancel without adding a fandom, or navigate away from the page, the work gets saved without a fandom.
(I reverted to a version of master prior to the fix for and confirmed that this was also the behaviour before the fix, the difference being that you got a 500 error instead of a message at step 2.)
Notes
You won’t necessarily see the lack of fandom on the work blurb or meta due to caching. However, if you return to the work’s edit page, you’ll see the Fandoms field is suspiciously empty.
Edited a work to remove the fandom, pressed Post, was redirected to the form with an error, pressed Cancel, got the same “The work was not updated” message as Nary and the work still had the fandom (I doubt checked by going to the edit page, which is not subject to caching).
Looks good!
Nary
June 22, 2021 at 12:13 AM
I tested this and was redirected back to the works listing with the message “The work was not updated.” The fandom on the work remained intact and looks correct, so this seems good to me!
redsummernight
March 28, 2020 at 3:20 AM
This issue is used to reproduce AO3-4936, so we should fix that one first and make testing easier.
Steps to reproduce:
Edit an existing work to remove its fandom and press Post.
Thanks to the fix in AO3-4808, an error message appears telling you the work is invalid because there is no fandom.
However, if you press Cancel without adding a fandom, or navigate away from the page, the work gets saved without a fandom.
(I reverted to a version of master prior to the fix for and confirmed that this was also the behaviour before the fix, the difference being that you got a 500 error instead of a message at step 2.)
Notes
You won’t necessarily see the lack of fandom on the work blurb or meta due to caching. However, if you return to the work’s edit page, you’ll see the Fandoms field is suspiciously empty.