Success message not being shown after account activation

Description

Steps to reproduce

  1. Log out

  2. Create an account, either by using an invitation code or logging in as an admin and changing the site settings to allow account creation without an invitation

  3. Follow the "activate your account" link in the "[AO3] Confirmation" email

What happens
You are redirected to the log in page with no indication your account has been activated.

What should happen
A blue flash notice should display, per this line in the users controller. The wording should probably change from "Signup complete" to "Account activation complete" for bonus clarity.

Notes
If you are confused by the lack of success message and follow the activation link a second time, you are redirected to the dashboard for the account you just created/activated. That page should have a message saying, “Your account has already been activated,” according to this line in the users controller. It does not. Ideally, both of these could be fixed at the same time; if not, we can punt this to another issue.

This is highest priority because it’s leading to a lot of support tickets, especially from Chinese users, increasing the workload of two committees.

Activity

Show:
ticking instant
February 9, 2020, 4:15 PM

Ah, I see what the other half of the issue is – the error message (and only the error message) uses flash.now[:error] instead of flash[:error], which only displays an error message for the current action (i.e. when you’re rendering a view), and not for the next action (i.e. after you redirect). Because it’s using flash.now in conjunction with a redirect, the message never gets displayed.

(It looks like there might be a couple of similar issues in the ChallengeRequestsController.)

Sarken
February 10, 2020, 5:51 AM

We need an nginx change on staging first. Then this can be set to QA.

C. Ryan Smith
February 13, 2020, 6:27 AM
Edited

Verified that blue notice appears on the login page!
ETA: Screenshot proof available if necessary.

lydia-theda
February 13, 2020, 7:32 AM

Successfully received the “account activation complete” message on a new account.

Got the “your account has already been activated” message on an already activated account, as well.

Sarken
February 14, 2020, 3:17 AM

Check a link I had used before and got taken to the account dashboard with a red flash message saying, “Your account has already been activated.”

So that’s two testers for the first message, two for the second. This is ready for release!

DeployedToBeta

Assignee

ticking instant

Reporter

Sarken

Roadmap

Users

Priority

Highest

Affects versions

Fix versions

Components

BackEnd

Difficulty

Easy

Milestone

Internal 0.9
Configure