Related Works page includes listings for works in anonymous and unrevealed collections
Description
A user's Related Works page will include listings of works inspired by works in unrevealed and anonymous collections.
Example:
https://test.archiveofourown.org/users/coaldustcanary/related_works
"Filth" (https://test.archiveofourown.org/works/1067371) is currently set as Unrevealed, but on my related works page, "Not at all filthy by testy5 " is listed as a related work. This was also the case when the collection was set to Anonymous.
To replicate:
Log in as User A
Post a work to an anonymous (or unrevealed) collection
Log out
Log in as User B
Post a work inspired by the work from Step 2
Go to the related works page for User A, i.e. https://test.archiveofourown.org/UserA/related_works
What happens:
The Related Works page for the creator of the anonymous/unrevealed work (User A) will list the work "inspired by" said work. This means everyone now knows that User A wrote the anonymous/unrevealed work.
What should happen:
This information should only be included if you are currently logged in as User A. Otherwise, works inspired by User A’s anonymous or unrevealed works should be excluded.
Notes:
There’s a similar issue that occurs if User A writes an anonymous or unrevealed work that’s marked as inspired by one of User B’s works. Those works are currently included on User A’s related works page as “A work in an unrevealed or anonymous challenge,” with a link to the inspiring work. This means that if the related work is approved, it’s fairly straightforward to track down User A’s anonymous work. (Just follow the link to the inspiring work, and check the “Works inspired by this one:” section.)
Instead, anonymous/unrevealed works by User A that are inspired by a work by User B should not be included on User A’s related works page for anyone other than User A. (It’s okay if they occur on User B’s related works page, though, as long as they don’t reveal the association with User A.)
This should also apply for translations, as well as remixes.
Activity
I'm pretty sure having that page accessible to all users is a mistake, since we hide the link to that page from everyone except the owner (i.e. if I'm logged in as testy, I can't see the "Related Works" link on testy2's dashboard).
The commented-out line of this cucumber test supports that:
EDIT: On the other hand, I was browsing old issues and found this:
So it looks like while the related works page was originally intended to be private, it was also supposed to be made suitable for public view at some point.
The issue was tested as said (User B added User A’s anonymous fic as inspiration), and it all looks good! User B’s work cannot be seen under Related Works of user A unless you’re logged in as User A.
Not convinced this is right, as testy
As zz9pzza
The related works page looks ok ?
Not sure if this counts as good enough ?
This is logged in as testy
Re: james_'s comment, we will handle the issue with unrevealed works in AO3-6058.
