Allow superadmins to disable guest comments across the site
Description
Activity
Sarken June 20, 2023 at 2:45 AM(edited)
Logged in with guest comments disabled:
on a work with
no one can comment
said “Sorry, this work doesn't allow comments” for work creator and other user, and hid reply button. A user blocked by the creator also saw the same message.
said “Sorry, the Archive doesn't allow guests to comment right now” for the guest and hid reply button
registered users can comment
allowed comments and replies by work creator and other user. A user blocked by the creator saw the usual block message and no reply button.
said “Sorry, the Archive doesn't allow guests to comment right now” and hid reply buttons for the guest
registered users and guests can comment
allowed comments and replies by work creator and other user. A user blocked by the creator saw the usual block message and no reply button.
said “Sorry, the Archive doesn't allow guests to comment right now” and hid reply buttons for the guest. Using the “Reply to this comment” link from an email also did not show me a reply form/button.
on a tag
I could comment normally while logged in as a wrangler
on a news post with
no one can comment
said “Sorry, this new post doesn't allow comments” for user and hid reply button.
said “Sorry, the Archive doesn't allow guests to comment right now” for the guest and hid reply button
registered users can comment
allowed comments and replies user.
said “Sorry, the Archive doesn't allow guests to comment right now” and hid reply buttons for the guest
registered users and guests can comment
allowed comments and replies by user.
said “Sorry, the Archive doesn't allow guests to comment right now” and hid reply buttons for the guest. Using the “Reply to this comment” link from an email also did not show me a reply form/button.
When I reenabled guest commenting, the “Sorry, the Archive doesn't allow guests to comment right now” banner stuck around in some places but not others, but that’s to be expected.
As a guest, I could once again comment and reply on things that were set to allow guest comments.
Things that only allowed registered users to comment showed the correct messages: “Sorry, this news post doesn't allow non-Archive users to comment. You can however contact Support with any feedback or questions” on news posts and “Sorry, this work doesn't allow non-Archive users to comment. You can however still leave Kudos!” on works. Reply buttons were not present.
Things that allowed no one to comment also showed the correct messages: “Sorry, this work doesn't allow comments” on works and “Sorry, this news post doesn't allow comments” on news posts. The reply buttons were absent.
Looks good! The one remaining thing I want to check is getting the form open on something, turning off guest comments, and then trying to submit the comment.
ETA: Tested that last thing! Got a red error saying, “Sorry, the Archive doesn't allow guests to comment right now.” Looks good to me! (Frost the Fox also reports getting the same results earlier, so that’s two testers on that scenario.)
V Snow June 20, 2023 at 2:20 AM
can see comments but cannot reply to any or make any. a blue box with “Sorry, the Archive doesn't allow guests to comment right now.” is visible
Sam Johnsson June 20, 2023 at 2:09 AM
Logged in as admin: Support
I can see the setting, but the box is greyed out.
Sam Johnsson June 20, 2023 at 1:47 AM
Navigated to https://test.archiveofourown.org/works/317416?show_comments=true#comments
Can see existing comments
see blue “Sorry, the Archive doesn't allow guests to comment right now.” box at top of comment section
none of the comments have a reply button
Click on thread. None of the comments in the thread view page have ‘reply’
james_ June 19, 2023 at 4:14 PM
Migration to happen before deploy
Log in as a superadmin
Go to Settings
What happens
There is no option to disable guest comments across the dingity dang site in case of spam attack.
What should happen
There should be. It should go under the option for hiding spam works and be called something like, “Turn off guest comments across the site.”
This should have the same general behavior as disabling guest comments on a specific work ( & ) / news post (), just on a larger scale. The message displayed should be, “Sorry, the Archive doesn’t allow guests to comment right now.” Ideally, the message would override the message that would be displayed if the individual commentable had comments disabled, so the same information is provided across the site, but this is negotiable.
It should not change the settings for an individual work/news post in the database, though; when we turn the setting off, we want works/news posts to go back to the way they were.
Deploy notes
bundle exec rake db:migrate:up VERSION=20230408145819